Bump onyx version / Preserve active report for each open tab #8759

mdneyazahmad · 2022-04-23T18:23:28Z

Details

When opened multiple report in different tabs, preserve the active report highlighting on sidebar (web only).

Fixed Issues

$ #7792

Tests

Web
1. Open app in tab 1
2. Select a report
3. Open app in tab 2
4. Select a different report
5. Verify that when we change the report in one tab it does not automatically changes the highlighted report(left sidebar). The left highlighted report should be exactly what report is opened in that tab.
Other platform
it should work as expected without any change.
Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Web
1. Open app in tab 1
2. Select a report
3. Open app in tab 2
4. Select a different report
5. Verify that when we change the report in one tab it does not automatically changes the highlighted report(left sidebar). The left highlighted report should be exactly what report is opened in that tab.
Other platform
it should work as expected without any change.
Verify that no errors appear in the JS console

Screenshots

Web

web.mp4

Mobile Web

mweb.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

rushatgabhane · 2022-04-24T21:38:36Z

We should get this merged after Expensify/react-native-onyx#124 is merged right??

mdneyazahmad · 2022-04-25T06:03:21Z

I am not sure about the process here. I have checked another pr with the onyx bump and it looks like this pr is required for testing and if it works fine the pr on onyx will be merged and we have to update the dependency in this repo to use the merged commit from onyx.

I am also not sure how will we test with only bump commit on this pr. We need some code changes to test this feature.

cc: @marcaaron @rushatgabhane

rushatgabhane · 2022-04-25T06:05:41Z

Well that does make some sense. @mdneyazahmad I think you could.. bump onyx in the original PR itself? And make all related changes in the same PR.

How does that sound like?

mdneyazahmad · 2022-04-25T06:20:16Z

@rushatgabhane I initially thought the same but based on @marcaaron suggestions I created this pr. I think we can wait for his comments.

Create a new PR that will update the version of react-native-onyx in Expensify/App package.json and add it to the Linked PRs section

Beamanator · 2022-04-25T11:13:32Z

@mananjadhav you're talking about this comment from @marcaaron right? Expensify/react-native-onyx#124 (comment)

I'm pretty sure he's saying this bump PR should be created after merging that onyx PR

marcaaron · 2022-04-25T16:47:39Z

We must wait til the react-native-onyx PR is merged and then use the merge commit sha in package.json. We should also implement the new option to solve the original issue.

marcaaron · 2022-04-25T16:48:44Z

Well that does make some sense. @mdneyazahmad I think you could.. bump onyx in the original PR itself? And make all related changes in the same PR.

Maybe we can close the original PR as we have a different solution now.

marcaaron · 2022-04-25T16:51:04Z

Please use this commit sha 7ab6aed5ce9158f7017ee1c9fd8b5d725d57db73, thanks!

mdneyazahmad · 2022-04-27T02:59:11Z

@marcaaron I have updated with the merge commit. Should I add the code fix (single line) to original issue here?

marcaaron · 2022-04-27T03:16:33Z

Should I add the code fix (single line) to original issue here?

👍

mdneyazahmad · 2022-04-27T07:43:17Z

Updated

rushatgabhane

This was a cool learning experience.
@Beamanator LGTM!

#### PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

Beamanator · 2022-04-27T11:41:48Z

@rushatgabhane it looks like you approved while suggesting changes? 😅

rushatgabhane · 2022-04-27T11:43:17Z

Oops 😬
fixed it

Beamanator · 2022-04-27T12:27:14Z

Nice work 👍 @mdneyazahmad can you also please update the PR title so it's more descriptive? Thanks 👍

OSBotify · 2022-04-27T12:36:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-05-09T20:05:06Z

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2022-05-13T16:14:05Z

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bump onyx version

43c14c2

mdneyazahmad requested a review from a team as a code owner April 23, 2022 18:23

melvin-bot bot requested review from Beamanator and rushatgabhane and removed request for a team April 23, 2022 18:23

mdneyazahmad mentioned this pull request Apr 23, 2022

feat: add config option to disable sync events for some keys Expensify/react-native-onyx#124

Merged

update with merged commit

953c373

fix: preserve sidebar active report highlight across tabs

8a7702a

mdneyazahmad mentioned this pull request Apr 27, 2022

[Fix] preserve sidebar active report highlight between tabs #8227

Closed

86 tasks

rushatgabhane suggested changes Apr 27, 2022

View reviewed changes

rushatgabhane approved these changes Apr 27, 2022

View reviewed changes

Beamanator approved these changes Apr 27, 2022

View reviewed changes

Beamanator merged commit d2c3224 into Expensify:main Apr 27, 2022

marcaaron assigned mdneyazahmad Apr 27, 2022

marcaaron changed the title ~~bump onyx version~~ Bump onyx version / Preserve active report for each open tab Apr 27, 2022

Beamanator mentioned this pull request May 9, 2022

[HOLD for payment 2022-05-20] [$500] Highlighted contact in LHN changes if you open a different chat in another tab - reported by @thesahindia #7792

Closed

OSBotify mentioned this pull request May 10, 2022

Deploy Checklist: New Expensify 2022-04-25 #8777

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump onyx version / Preserve active report for each open tab #8759

Bump onyx version / Preserve active report for each open tab #8759

mdneyazahmad commented Apr 23, 2022 •

edited

Loading

rushatgabhane commented Apr 24, 2022

mdneyazahmad commented Apr 25, 2022

rushatgabhane commented Apr 25, 2022

mdneyazahmad commented Apr 25, 2022

Beamanator commented Apr 25, 2022

marcaaron commented Apr 25, 2022

marcaaron commented Apr 25, 2022

marcaaron commented Apr 25, 2022

mdneyazahmad commented Apr 27, 2022

marcaaron commented Apr 27, 2022

mdneyazahmad commented Apr 27, 2022

rushatgabhane left a comment •

edited

Loading

Beamanator commented Apr 27, 2022

rushatgabhane commented Apr 27, 2022

Beamanator commented Apr 27, 2022

OSBotify commented Apr 27, 2022

OSBotify commented May 9, 2022

OSBotify commented May 13, 2022

Bump onyx version / Preserve active report for each open tab #8759

Bump onyx version / Preserve active report for each open tab #8759

Conversation

mdneyazahmad commented Apr 23, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

rushatgabhane commented Apr 24, 2022

mdneyazahmad commented Apr 25, 2022

rushatgabhane commented Apr 25, 2022

mdneyazahmad commented Apr 25, 2022

Beamanator commented Apr 25, 2022

marcaaron commented Apr 25, 2022

marcaaron commented Apr 25, 2022

marcaaron commented Apr 25, 2022

mdneyazahmad commented Apr 27, 2022

marcaaron commented Apr 27, 2022

mdneyazahmad commented Apr 27, 2022

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

#### PR Reviewer Checklist

Beamanator commented Apr 27, 2022

rushatgabhane commented Apr 27, 2022

Beamanator commented Apr 27, 2022

OSBotify commented Apr 27, 2022

OSBotify commented May 9, 2022

OSBotify commented May 13, 2022

mdneyazahmad commented Apr 23, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading