-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust webpack type to apple-app-site-association #8803
Conversation
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I ran a local web build with npm run build
and verified that this file is under .well-known/apple-app-site-association
rather than .well-known/apple-app-site-association/apple-app-site-association
I guess we should wait to merge since #8777 has the LockCashDeploys label? |
I'm pretty sure the CP Staging tag bypasses the lock and this is needed to test a PR on the checklist so it should be fine |
Adjust webpack type to apple-app-site-association (cherry picked from commit def3fa6)
…8803 🍒 Cherry pick PR #8803 to staging 🍒
Nice, https://staging.new.expensify.com/.well-known/apple-app-site-association shows the new file |
🚀 Cherry-picked to staging by @neil-marcellini in version: 1.1.57-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Details
Fixed Issues
The fiIe was getting deployed to a folder because webpack automatically tried to infer the type based on the extension but apple-app-site-association is a file not a folder
https://expensify.slack.com/archives/C03TQ48KC/p1651080349065949
Tests
PR Review Checklist
N/A
QA Steps
Screenshots
Web
Mobile Web
Desktop
iOS
Android