Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust webpack type to apple-app-site-association #8803

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

thienlnam
Copy link
Contributor

@thienlnam thienlnam commented Apr 27, 2022

Details

Fixed Issues

The fiIe was getting deployed to a folder because webpack automatically tried to infer the type based on the extension but apple-app-site-association is a file not a folder

https://expensify.slack.com/archives/C03TQ48KC/p1651080349065949

Tests

  • Create production build locally and ensure you don't run into errors

PR Review Checklist

N/A

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@thienlnam thienlnam requested a review from a team as a code owner April 27, 2022 17:51
@melvin-bot
Copy link

melvin-bot bot commented Apr 27, 2022

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@thienlnam thienlnam self-assigned this Apr 27, 2022
@melvin-bot melvin-bot bot requested review from neil-marcellini and removed request for a team April 27, 2022 17:51
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@thienlnam thienlnam mentioned this pull request Apr 27, 2022
89 tasks
@thienlnam thienlnam changed the title Adjust webpack type to file Adjust webpack type to apple-app-site-association Apr 27, 2022
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I ran a local web build with npm run build and verified that this file is under .well-known/apple-app-site-association rather than .well-known/apple-app-site-association/apple-app-site-association

@neil-marcellini
Copy link
Contributor

I guess we should wait to merge since #8777 has the LockCashDeploys label?

@thienlnam
Copy link
Contributor Author

thienlnam commented Apr 27, 2022

I'm pretty sure the CP Staging tag bypasses the lock and this is needed to test a PR on the checklist so it should be fine

@neil-marcellini neil-marcellini merged commit def3fa6 into main Apr 27, 2022
@neil-marcellini neil-marcellini deleted the jack-deployToFile branch April 27, 2022 18:18
OSBotify pushed a commit that referenced this pull request Apr 27, 2022
Adjust webpack type to apple-app-site-association

(cherry picked from commit def3fa6)
OSBotify added a commit that referenced this pull request Apr 27, 2022
@thienlnam
Copy link
Contributor Author

Nice, https://staging.new.expensify.com/.well-known/apple-app-site-association shows the new file

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @neil-marcellini in version: 1.1.57-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants