Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Fix: Storybook Build #8880

Merged
merged 1 commit into from
May 5, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented May 5, 2022

Details

Fixed Issues

$ GH_LINK

Tests

  1. Run the build locally.
  • Verify that no errors appear in the JS console

Screenshots

image

@parasharrajat parasharrajat requested a review from a team as a code owner May 5, 2022 13:35
@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team May 5, 2022 13:35
@arosiclair arosiclair merged commit 8d6368e into Expensify:main May 5, 2022
@OSBotify
Copy link
Contributor

OSBotify commented May 5, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 9, 2022

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants