Update to latest version of eslint-config-expensify #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After merging this, you can unhold https://github.com/Expensify/Web-Expensify/pull/31783 |
|
Were you able to test that this doesn't break iframes and tooltips? Do you want to add that to the PR tests? |
tgolen
approved these changes
Aug 25, 2021
|
Oh, sorry, check the tests in the web-e PR and let me know if they are enough or I missed something. |
Wait, tooltips? I don't think I touched that here... |
|
Oh, sorry. I meant combobox, not tooltip. I'll see if I can find the web-e PR |
|
It's here https://github.com/Expensify/Web-Expensify/pull/31783 I linked it in my comment above |
|
ah, haha, I'm just going everywhere this morning. Yeah, that looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TAG_REVIEWER will you please review this?
[Explanation of the change or anything fishy that is going on]
Fixed Issues
#407 (comment)
Tests
See https://github.com/Expensify/Web-Expensify/pull/31783