setup.py missing universal truth in setup_req*.txt #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: Fixes F5Networks#958 Problem: * `setup_requirements.txt` missing from `setup.py` Analysis: * This adds it and allows for pip library to exist for redhat and ubuntu * Both required for build Dockerfile's Tests: This is driven by the: `./f5-openstack-agent-dist/scripts/test_install.sh` Test script for building packages and validating them.
ssorenso
force-pushed
the
liberty.setup_universal_truth_fix.958
branch
from
c0cb4bb to
f601555
Compare
|
@ssorenso: the config on the smoke tests was wiped when the job was disabled. That is why you see two lines showing up referring to smoke tests above. If we open new pull requests, we should only get one message: 'Running smoke tests on PR' |
|
retest this please |
|
To assure that the RPM and DEB packages are correct and working, this needs to be in before Friday's releases. |
|
This change now needs some serious TLC. I will fix this shortly and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #958
Problem:
setup_requirements.txtmissing fromsetup.pyAnalysis:
Tests:
This is driven by the:
./f5-openstack-agent-dist/scripts/test_install.shTest script for building packages and validating them.
@zancas
What issues does this address?
Fixes #958
What's this change do?
Where should the reviewer start?
setup.py
Any background context?
The setup.py had to be modified as well as both build Dockerfile's (redhat and ubuntu)