Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint23 EM v3 and microstructure replacing #267 and #270 #278

Merged
merged 83 commits into from
Sep 11, 2024

Conversation

mkuehbach
Copy link
Collaborator

No description provided.

mkuehbach and others added 30 commits June 25, 2024 17:53
… NXcomponent for technical components through removing electron microscopy specificity
… replaced all locations where NXaperture_em was used for NXaperture
…more meaty base class NXimage_set, the partner in crime for NXspectrum_set
…asses

Fused NXimage_r_set, NXimage_c_set, NXimage_r_set_diff into a single …
Promote component_em to generally usable base class NXcomponent
…NXms with NXmicrostructure to avoid confusing the symbol convention with mass spectrometry as the abbreviation NXms may suggest
…cision of concept image and how this is connected to tilings
…ns as dependants of specific method results, introduction of NXatom_set to discuss generalization of NXion towards enabling descriptions of groups of atoms, also to lias with FAIRmat Area C
…unter variables in case one does not know the actual dimensions but one is sure it is not a scalar
@mkuehbach mkuehbach marked this pull request as ready for review September 4, 2024 15:58
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small remaining comments, but nothing that should change functionality

Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkuehbach mkuehbach merged commit 05df4f0 into fairmat Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants