Remove middleman: ESD is the model now, not STAModel #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The two issues above have now been addressed |
This was referenced Apr 12, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the skin was removed, STAModel was created to separate model concerns from view concerns. However, this was before EditableStyledDocument became a public interface. Now that ESD is a public interface, STAModel does nothing more than delegate method calls to that object and handle positions of things within the document (caretPosition, caretColumn, selectedText, etc.)
As of now, this build currently fails because STAModelTest can not create a STAModel. This can be resolved by using TestFX to create an area and then run the tests.
Even so, since #333 should be done, these tests shouldn't matter.
However, I believe more of the model-related things should still be stored in EditableStyledDocument (e.g., the
SuspendableVals for various things [text, paragraphs, etc.]) as these values only need to be stored in one object, not stored in each view. I still need to do this.