Allow UndoManager to use developer-defined changes (text, view, etc.) #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #333
One cannot pass in an
UndoManageras an argument since itsapplyConsumer requires the area to already be constructed. As such, the area still constructs the defaultUndoManager. However, once the area is constructed, this PR now allows one to set the area's undoManager directly and not indirectly through anUndoManagerFactory.Thus, one has complete control over how the
UndoManageris constructed and functions. It could only handle changes to the area's text, only changes to the area's view, or something else altogether.Future PRs could add other factory methods for constructing
UndoManagers that work differently.