QML rewrite: use a reusable base "Page" component for each UI page #733
Conversation
grulja
force-pushed
the
cleanup
branch
2 times, most recently
from
e01ce4b to
4ef7c17
Compare
There was a problem hiding this comment.
Code LGTM, but I've tried to comapre it to main version
Left: main x Right: this
Here it looks like the buttons are slightly stretched
Here it looks like the Heading is slightly smaller on cleanup version and the entire content inside the FMW is wider
Also it looks like the "Download & Write" is not working in either of them (but might be just WSL Fedora problem :D)
I think this is a bug in QtSvg as the image is not fully painted and most likely it breaks sizing. Using the other image here it looks good and similar to the original.
That I think is fine. I just removed some margins specified all over the place so it's just unified.
I made it bigger now.
Not probably related to this change. |
This "Page" component also now includes buttons, which originally were part of the main UI, where we also had the complete logic for what text and actions should be used for both buttons at different state. Moving this to per page component makes things simpler, easier to understand and less error prone. It also removes quite a lot of code.
This "Page" component also now includes buttons, which originally were part of the main UI, where we also had the complete logic for what text actions should be used for both buttons at different state. Moving to per page component makes things simpler, easier to understand less error prone. It also removes quite a lot of code.