Make AMQP header properties available #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, there is no way to pass these headers directly to the handler function since the handler function is called by the Thrift generated code and that code has no way to add in extra parameters not declared in the Thrift file. However, we do know that node is single thread. So, what we can do is make the properties available as a property on the AMQPServer object. From there, we can copy them into the handler's body. Since Node is single threaded, we can be sure that between the time that this variable is set on the AMQPServer object and when the handler function initially runs, no other messages will be processed. As soon as the handler exits, of course, another message may be received - but sinced we've saved them to a variable in our handler function, we don't have to worry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, there is no way to pass these headers directly to the
handler function since the handler function is called by the Thrift
generated code and that code has no way to add in extra parameters not
declared in the Thrift file. However, we do know that node is single
thread. So, what we can do is make the properties available as a
property on the AMQPServer object. From there, we can copy them into the
handler's body. Since Node is single threaded, we can be sure that
between the time that this variable is set on the AMQPServer object and
when the handler function initially runs, no other messages will be
processed. As soon as the handler exits, of course, another message may
be received - but sinced we've saved them to a variable in our handler
function, we don't have to worry about that.