Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webp closes on dropdown Gesture #409

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RaJansuMan
Copy link

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added a variable to retrieve the initial zoom level from GestureImageView, as it may not always initialize with a 1f zoom.
  • Introduced a boolean flag to ensure only initial zoom is set.
  • Added a maximum zoom difference threshold to account for minor decimal variations when zooming out, as double tap zoom out may occasionally not reset to the exact same initial value.

Before/After Screenshots/Screen Record

  • Before:
Record_2025-02-28-16-08-41.mp4
  • After:
Record_2025-02-28-16-07-19.1.mp4

Fixes the following issue(s)

Acknowledgement

@naveensingh
Copy link
Member

Seems to work fine, thanks!

Two things:

  • Please format the code
  • Rename MAX_ZOOM_DIFFERENCE to MAX_ZOOM_TOLERANCE or something more descriptive to indicate what it's for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants