Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: added ability to toggle between selected languages #40

Closed
wants to merge 1 commit into from

Conversation

ronniedroid
Copy link
Contributor

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added a toggle languages button between the emoji key and the space bar (In all languages layouts)
  • Removed the comma key (as we can reach the comma by long pressing the period key)
  • Moved the select language secondary key (popup) to the newly added toggle languages key
  • Made sure the icon of the key is visible in light and dark themes (by applying appropriate colors)
  • Implemented the functionality to toggle between the languages

Before/After Screenshots/Screen Record

  • After:

Acknowledgement

@ronniedroid
Copy link
Contributor Author

@naveensingh sorry I did not wait for the discussion to be resolved, I had some time to spare today and decided to put this here in case you would like to merge it before the first release. I added the toggle key at the bottom row, in case you want it in the toolbar instead of at the bottom row, let me know and I will move it there. best regards.

@Aga-C
Copy link
Member

Aga-C commented May 26, 2024

I think comma is a popular character, and we can't just remove its separate button. I haven't seen the keyboard without a comma button. Maybe you should do it similarly as it is in Gboard - emojis are moved to the comma long-press, so there's a place for language change button between comma and space bar.

@ronniedroid
Copy link
Contributor Author

I think comma is a popular character, and we can't just remove its separate button. I haven't seen the keyboard without a comma button. Maybe you should do it similarly as it is in Gboard - emojis are moved to the comma long-press, so there's a place for language change button between comma and space bar.

The AOSP keyboard doesn't have a dedicated comma key, but your idea also sounds good, should I do that?

@Aga-C
Copy link
Member

Aga-C commented May 26, 2024

I don't know, you may try if you like. If I were you, I'd wait a bit, maybe Naveen will give his opinion soon.

@ronniedroid
Copy link
Contributor Author

I just noticed that I have put the button to the left of the emoji key and not the right 😅, will fix later.

@naveensingh
Copy link
Member

Closing because #25 (comment)

@ronniedroid ronniedroid mentioned this pull request Sep 15, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants