Correct errors in Push API #7262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the footnotes about Safari on macOS. "Partial support" should only apply to Safari 16.1-17.7, since after that it's impossible to run Safari 18.0+ on a version of macOS that does not support Web Push. Changing the note requires splitting one of the footnotes (and thus renumbering the iOS footnotes.)
Updating footnote about web push on iOS and iPadOS. "Delivered silently, meaning no sound, vibration, haptics or screen wake" is not a true statement. Notifications can have sound, vibration, and wake the screen — it's in the user's control whether they do or not, exactly like other push notifications on iOS. More info at: https://webkit.org/blog/13878/web-push-for-web-apps-on-ios-and-ipados/
|
Thanks! Looked into it a bit and it seemed that line came from #6688. I believe that was an issue that occurred while the feature was in beta but then got fixed (via this reddit thread), so agree it can be removed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting two mistakes in data about support in Safari:
"Partial support" on macOS is due to the requirement for macOS Ventura. That requirement no longer applies for Safari 18.0+. In order to apply this note to Safari 16.1-17.7 only, I split footnote 5 ("Only available on macOS 13 Ventura or later and only in Safari itself, not WKWebView nor SFSafariViewController") into two separate footnotes.
Footnote 6 currently reads "Requires website to first be added to the Home Screen. Delivered silently, meaning no sound, vibration, haptics or screen wake." First, this footnote is being renumbered as footnote 7 (to make 5 become 5 & 6). Second, the claim "Delivered silently, meaning no sound, vibration, haptics or screen wake" is untrue — so I've simply deleted the sentence. More information about how sound, vibration, haptics or screen wake work with Web Push on iOS is available at https://webkit.org/blog/12945/meet-web-push/.