Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing redundant note from WebGPU #7273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jensimmons
Copy link
Contributor

I noticed the page for WebGPU says "All major browser engines are working on implementing this spec. All major browser engines are working on implementing this spec."

Hm. The same sentence twice? I came here to fix it. But in JSON, it's only there once. Interesting. Well, this note isn't needed at all in Feb 2025, since seeing feature flags for both WebKit and Gecko browsers tells the same story. So I'm deleting it, expecting that will fix the bug as well.

Screenshot 2025-02-28 at 1 42 08 PM

I noticed the page for WebGPU says "All major browser engines are working on implementing this spec. All major browser engines are working on implementing this spec."

Hm. The same sentence twice? I came here to fix it. But in JSON, it's only there once. Interesting. Well, this note isn't needed at all in Feb 2025, since seeing feature flags for both WebKit and Gecko browsers tells the same story. So I'm deleting it, expecting that will fix the bug as well.
@@ -657,7 +657,6 @@
"3.0-3.1":"n d #1"
}
},
"notes":"All major browser engines are working on implementing this spec.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would need to be

"notes":"",

to make the pipeline happy :)

(sadly I can't add it as a proper easy to apply suggestion)

Fixing mistake in P.R.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants