Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.16.0 #76

Merged
merged 17 commits into from
Nov 3, 2023
Merged

5.16.0 #76

merged 17 commits into from
Nov 3, 2023

Conversation

ppouchin
Copy link
Member

@ppouchin ppouchin commented Nov 3, 2023

No description provided.

@@ -92,6 +92,7 @@
DatasetWrapper newDataset = client.getDataset(id);

newDataset.addImages(client, images);
newDataset.refresh(client);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [GenericRepositoryObjectWrapper.refresh](1) should be avoided because it has been deprecated.
@@ -51,6 +51,7 @@

boolean imported = dataset.importImages(client, 2, f1.getAbsolutePath(), f2.getAbsolutePath());
client.closeImport();
dataset.refresh(client);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [GenericRepositoryObjectWrapper.refresh](1) should be avoided because it has been deprecated.
@@ -242,7 +242,9 @@
assertEquals(2, folders.size());
assertEquals(nImages, image.getROIs(client).size());

for (FolderWrapper f : folders) f.reload(client);
for (FolderWrapper f : folders) {
f.reload(client);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [FolderWrapper.reload](1) should be avoided because it has been deprecated.
@@ -64,6 +65,7 @@

int initialSize = project.getDatasets().size();
project.addDataset(client, dataset);
project.refresh(client);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [GenericRepositoryObjectWrapper.refresh](1) should be avoided because it has been deprecated.
@@ -175,6 +175,7 @@
ScreenWrapper screen = new ScreenWrapper(client, "Import", "test-import");

boolean imported = screen.importImages(client, f1.getAbsolutePath(), f2.getAbsolutePath());
screen.refresh(client);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [GenericRepositoryObjectWrapper.refresh](1) should be avoided because it has been deprecated.
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (0ac78e2) 95.46% compared to head (dcb1504) 95.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #76      +/-   ##
============================================
+ Coverage     95.46%   95.49%   +0.02%     
- Complexity     1154     1210      +56     
============================================
  Files            45       46       +1     
  Lines          3064     3238     +174     
  Branches        244      260      +16     
============================================
+ Hits           2925     3092     +167     
- Misses           78       85       +7     
  Partials         61       61              
Files Coverage Δ
...c/main/java/fr/igred/omero/AnnotatableWrapper.java 97.33% <100.00%> (-0.06%) ⬇️
src/main/java/fr/igred/omero/Browser.java 99.57% <100.00%> (+<0.01%) ⬆️
src/main/java/fr/igred/omero/Client.java 100.00% <100.00%> (ø)
src/main/java/fr/igred/omero/GatewayWrapper.java 95.23% <100.00%> (+0.04%) ⬆️
...main/java/fr/igred/omero/GenericObjectWrapper.java 100.00% <100.00%> (ø)
...igred/omero/annotations/FileAnnotationWrapper.java 90.90% <ø> (ø)
...ed/omero/annotations/GenericAnnotationWrapper.java 100.00% <ø> (ø)
.../igred/omero/annotations/TagAnnotationWrapper.java 90.90% <100.00%> (+2.02%) ⬆️
...java/fr/igred/omero/annotations/TagSetWrapper.java 100.00% <100.00%> (ø)
...ava/fr/igred/omero/exception/ServiceException.java 100.00% <100.00%> (ø)
... and 18 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

96.8% 96.8% Coverage
0.0% 0.0% Duplication

@ppouchin ppouchin merged commit c11c615 into main Nov 3, 2023
@ppouchin ppouchin deleted the dev branch November 3, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant