Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting discovery demo for solubility task #182

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

jannisborn
Copy link
Contributor

  • Solving Adding more components to the target scoring function #181: Improving PaccMannGP to support arbitrary callables as suggested in the discussion
  • Adding a new model PaccMannVAE that produces unconditional molecules. It's the same decoder as in PaccMannRL but just used by sampling randomly. We basically just wrap the PaccMannRL model.
  • Adapting the case study on GENTRL's DDR1-inhibitor to optimize solubility instead of QED. Reran all the models, including the new one (PaccMannVAE). Findings are the same in that MoLeR and RT are performing the best

@jannisborn jannisborn added the enhancement New feature or request label Jan 6, 2023
@jannisborn jannisborn requested a review from drugilsberg January 6, 2023 08:36
@cla-bot cla-bot bot added the cla-signed CLA has been signed label Jan 6, 2023
Copy link
Contributor

@drugilsberg drugilsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good, I did not have a chance to run the full notebook, but the logic and the updates look good.

@drugilsberg
Copy link
Contributor

@jannisborn small build due to a PaccMannGP test:

if self.mode == "max":
[5965](https://github.com/GT4SD/gt4sd-core/actions/runs/3853838762/jobs/6567211532#step:9:5966)
            return 1 - (sum(values) / len(values))
[5966](https://github.com/GT4SD/gt4sd-core/actions/runs/3853838762/jobs/6567211532#step:9:5967)
        elif self.mode == "min":
[5967](https://github.com/GT4SD/gt4sd-core/actions/runs/3853838762/jobs/6567211532#step:9:5968)
>           return sum(values) / len(values)
[5968](https://github.com/GT4SD/gt4sd-core/actions/runs/3853838762/jobs/6567211532#step:9:5969)
E           ZeroDivisionError: division by zero

Looks like it is something dependent on the error handling in the scoring function in the package.

@drugilsberg drugilsberg merged commit 3738fee into GT4SD:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA has been signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants