Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a handful of broken animations #868

Merged
merged 7 commits into from
Feb 18, 2025
Merged

Fix a handful of broken animations #868

merged 7 commits into from
Feb 18, 2025

Conversation

RecursivePineapple
Copy link
Contributor

@RecursivePineapple RecursivePineapple commented Feb 13, 2025

This fixes a few of the remaining broken animations, and does so in a way that should be relatively future-proof. It hooks into the getMinU method instead of requiring renderers to mark IIcons dirty. Unfortunately this means that it requires a thread local stack, but I haven't noticed a performance hit at all. The thread local is only accessed when a chunk is rebuilt, so even if it's a slight performance hit, it shouldn't be noticeable.

In-world modded liquids are still broken, but I can't be bothered to figure out why since no one looks at them anyways.

Here's a spark profile from me spamming f3 + a. It didn't capture any of the worker threads, but I didn't notice any obvious slowdowns or memory leaks.
https://spark.lucko.me/pkwQWC2Sfr

These gifs loop very poorly, but that's from the recording software I used. In game the animations are fine.

Some fixed animations (catalyst housing & soul fire) + sanity test:
anim 1

Fixed controller animations (they were so slow they were unnoticeable):
anim 2
anim 3

@Dream-Master Dream-Master requested review from mitchej123 and a team February 13, 2025 10:57
@RecursivePineapple
Copy link
Contributor Author

RecursivePineapple commented Feb 14, 2025

This should fix items that are rendered abnormally too. These gt spnt items weren't rendering animating previously.

spnt.mp4

Copy link
Collaborator

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One implementation nitpick.

@mitchej123 mitchej123 enabled auto-merge (squash) February 18, 2025 18:26
@mitchej123 mitchej123 merged commit 67c8628 into master Feb 18, 2025
1 check passed
@mitchej123 mitchej123 deleted the fix-some-animations branch February 18, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants