Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1937: Fix layers settings for internal layers #1943

Merged
merged 1 commit into from
Feb 5, 2025
Merged

#1937: Fix layers settings for internal layers #1943

merged 1 commit into from
Feb 5, 2025

Conversation

dsuren1
Copy link

@dsuren1 dsuren1 commented Jan 21, 2025

Description

This PR fixes the layer settings component used for internal layers

Issue

@dsuren1 dsuren1 added bug Something isn't working geonode-ui 4.4.x labels Jan 21, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap January 21, 2025 06:35
@dsuren1 dsuren1 self-assigned this Jan 21, 2025
@dsuren1 dsuren1 linked an issue Jan 21, 2025 that may be closed by this pull request
The layers settings for internal layers are using the wrong component #1937
Closed
allyoucanmap
allyoucanmap requested changes Feb 4, 2025
View reviewed changes
geonode_mapstore_client/static/mapstore/configs/localConfig.json
Comment on lines +90 to +93
},
{
"name": "selectedLayer",
"path": "gnresource.selectedLayer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsuren1 is it possible to use just one of gnResourceSelectedLayerDataset or selectedLayer or do they are different?
Could you investigate on where the gnResourceSelectedLayerDataset is used and if it can be replaced by selectedLayer, thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allyoucanmap It seems each holds a different data. selectedLayer holds selected node (layer) and selectedLayerDataset holds dataset info available in mapLayers by selected node

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the dataset fetch is asynchronous, there is a visual transition between TOCItemSetting and the LayerSetting plugin as the dataset is being retrieved. Therefore, I believe we should proceed with the current implementation as agreed

@allyoucanmap allyoucanmap merged commit 89a25af into GeoNode:master Feb 5, 2025
4 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@dsuren1 @github-actions
#1937: Fix layers settings for internal layers (#1943)
b35f21a 
(cherry picked from commit 89a25af)
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Merged
giohappy pushed a commit that referenced this pull request Feb 5, 2025
@github-actions @dsuren1
#1937: Fix layers settings for internal layers (#1943) (#1953)
f8c880e 
(cherry picked from commit 89a25af)

Co-authored-by: Suren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@dsuren1 dsuren1

Labels
4.4.x backport 4.4.x bug Something isn't working geonode-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The layers settings for internal layers are using the wrong component
2 participants
@dsuren1 @allyoucanmap