Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move mention styling outside message #325

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

arnautov-anton
Copy link
Contributor

🎯 Goal

Adjust styling of the mention span element so it gets picked up within message, quoted message and quoted message within message input.

Before:
image
After:
image

@arnautov-anton arnautov-anton merged commit fb5e0a4 into main Feb 19, 2025
1 check passed
@arnautov-anton arnautov-anton deleted the fix/remove-mention-styling-message-limit branch February 19, 2025 09:17
github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
## [5.7.1](v5.7.0...v5.7.1) (2025-02-19)

### Bug Fixes

* add margin only to other users' messages without open actions dialog ([#324](#324)) ([5231325](5231325))
* move mention styling outside message ([#325](#325)) ([fb5e0a4](fb5e0a4))
Copy link

🎉 This PR is included in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

arnautov-anton added a commit to GetStream/stream-chat-react that referenced this pull request Feb 19, 2025
### 🎯 Goal

Currently, Markdown text is not being rendered properly within quoted
messages (`renderText` omitted). This PR aims at adding `renderText` to
both `QuotedMessage` and `QuotedMessagePreview` components.

#### Missing

- [x] CSS adjustment to mention `span` selector (must include message
input too), [PR](GetStream/stream-chat-css#325)
- [x] tests,
[07fc7cf](07fc7cf)

#### DO NOT MERGE BEFORE INSTALLING LATEST `@stream-io/stream-chat-css`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants