Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: channel pinning and archiving #2866

Merged
merged 24 commits into from
Jan 29, 2025
Merged

feat: channel pinning and archiving #2866

merged 24 commits into from
Jan 29, 2025

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Dec 26, 2024 •
edited
Loading

🎯 Goal

The goal of the PR is to add channel pinning and archiving feature to the SDK.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Dec 26, 2024 •
edited
Loading

SDK Size

title develop branch diff status
js_bundle_size 463 KB 466 KB +2824 B 🔴

@khushal87 khushal87 marked this pull request as ready for review January 22, 2025 08:28
isekovanic
isekovanic approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the single comment looks good !

@khushal87 khushal87 merged commit 9cf8832 into develop Jan 29, 2025
4 of 5 checks passed
@khushal87 khushal87 deleted the channel-pinning-and-archiving branch January 29, 2025 07:43
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Merged
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isekovanic isekovanic isekovanic approved these changes

@arnautov-anton arnautov-anton arnautov-anton approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khushal87 @Stream-SDK-Bot @stream-ci-bot @isekovanic @arnautov-anton