fix: audio attachment reset to 0 issue and refinements #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve into audio-attachment-fix
SDK Size
|
isekovanic
reviewed
Jan 24, 2025
isekovanic
reviewed
Jan 24, 2025
isekovanic
reviewed
Jan 24, 2025
isekovanic
approved these changes
Jan 24, 2025
isekovanic
reviewed
Jan 28, 2025
isekovanic
reviewed
Jan 28, 2025
isekovanic
reviewed
Jan 28, 2025
package/src/components/ImageGallery/components/ImageGalleryVideoControl.tsx
Show resolved
Hide resolved
isekovanic
reviewed
Jan 28, 2025
isekovanic
reviewed
Jan 28, 2025
isekovanic
reviewed
Jan 28, 2025
…ve into audio-attachment-fix
Merged
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to fix the issue where when the audio attachment play reached the end, it didn't reset to 0. The PR also introduces a hook,
useAudioPlayer,that handles and exposes functions for easy usage in the code, making the code cleaner. I have improved the progress bar and the waveform progress bar to return and intercept to progress in the range 0-1 which makes the handling simpler.