Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change the address, once you set it the first time. #1

Closed
beargun opened this issue Mar 4, 2017 · 2 comments
Closed

Unable to change the address, once you set it the first time. #1

beargun opened this issue Mar 4, 2017 · 2 comments

Comments

@beargun
Copy link

beargun commented Mar 4, 2017

Once setting the I2C address, using the S option has no effect.

Steps to reproduce

  • type S80 to select address 80
  • type S81 to select address 81
  • address is however still set to 80

This is because typing S will call the EEPROM_I2C_setAddress(); function, which will return the new address. However, nothing is done with the returned value.

Fix:
Change line 213 from EEPROM_I2C_setAddress(); to I2C_ADDRESS = EEPROM_I2C_setAddress();

PS, thanks for the awesome tool. Though it took me quite some time to figure out this problem, as I though it was an hardware issue, instead of the software I was using to read (-:

Ghostbird added a commit that referenced this issue Mar 4, 2017
Ghostbird added a commit that referenced this issue Mar 4, 2017
@Ghostbird
Copy link
Owner

Ghostbird commented Mar 4, 2017

Fix has been merged. Thanks for the heads up.
Note that I do not have a test set-up available, so I'd be much obliged if you could verify the correctness of the fix. (I made a few extra, mainly cosmetic, changes.)

@beargun
Copy link
Author

beargun commented Mar 9, 2017

Everything is working perfectly. I have verified it with a 2kbit EEPROM and my logic analyzer.

Thanks for the fast fix.

@beargun beargun closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants