Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate external databases #817

Closed
vrongmeal opened this issue Apr 4, 2023 · 2 comments · Fixed by #880
Closed

Validate external databases #817

vrongmeal opened this issue Apr 4, 2023 · 2 comments · Fixed by #880
Labels
bug Something isn't working

Comments

@vrongmeal
Copy link
Contributor

Summary

Similar to how we used to validate external connections, validate external datasources.

Specifications

Rationale

To provide a better user-experience.

Impact

Tasks
@vrongmeal vrongmeal added the feat New feature or request label Apr 4, 2023
@greyscaled greyscaled added bug Something isn't working and removed feat New feature or request labels Apr 10, 2023
@greyscaled
Copy link
Contributor

  • we don't check the connection on create
  • we already have stuff we were calling when validating connection --> rework

@greyscaled
Copy link
Contributor

2023-04-17:

  • Check on priority
  • Check on "what" is missing

vrongmeal added a commit that referenced this issue Apr 17, 2023
@vrongmeal
fix: implement external database validation for all sources
8ed7074 
Fixes: #817

Signed-off-by: Vaibhav <[email protected]>
@vrongmeal vrongmeal mentioned this issue Apr 17, 2023
Merged
vrongmeal added a commit that referenced this issue Apr 17, 2023
@vrongmeal
fix: implement external database validation for all sources (#880)
7b7bcf2 
Fixes: #817

Signed-off-by: Vaibhav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: implement external database validation for all sources GlareDB/glaredb
2 participants
@greyscaled @vrongmeal