Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add highlighting & multiline sql support #1091

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

universalmind303
Copy link
Contributor

adds support for the following to the cli:

  • syntax highlighting,
  • multiline support (as is common with other sql interfaces.)
  • history autofill

image

partially closes #1090

@universalmind303 universalmind303 force-pushed the terminal-highlighting branch from 68e3b90 to bdfddd8 Compare June 5, 2023 18:29
Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for opening a pr.

@greyscaled can you check that that this works well on wsl?

@greyscaled greyscaled self-requested a review June 5, 2023 20:30
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on wsl, worked well!

@scsmithr scsmithr merged commit 7f7c116 into GlareDB:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sql syntax highlighting & formatting to terminal
3 participants