Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow specifying user and password as commandline #1118

Merged
merged 5 commits into from
Jun 9, 2023
Merged

feat: Allow specifying user and password as commandline #1118

merged 5 commits into from
Jun 9, 2023

Conversation

scsmithr
Copy link
Member

@scsmithr scsmithr commented Jun 9, 2023 •
edited
Loading

Closes #1117

  • Adds --user and --password args for a simple auth setup
  • Removes the --local flag

By default, glaredb server will spin up a server that has password auth disabled. Specifying --password will then require a client to provide the correct user and password.

@scsmithr scsmithr changed the title feat: Allow specifying user and password as commandline args feat: Allow specifying user and password as commandline Jun 9, 2023
@scsmithr scsmithr requested a review from vrongmeal June 9, 2023 20:03
@scsmithr scsmithr requested a review from greyscaled June 9, 2023 20:04
@scsmithr scsmithr merged commit ac519cd into main Jun 9, 2023
@scsmithr scsmithr deleted the sean/single-user-auth branch June 9, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled approved these changes

@vrongmeal vrongmeal Awaiting requested review from vrongmeal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying user and password when running glaredb server
2 participants
@scsmithr @greyscaled