feat: COPY TO support
#1159
Merged
feat: COPY TO support
#1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrongmeal
force-pushed
the
vrongmeal/copy-to
branch
2 times, most recently
from
a082f93 to
d572135
Compare
vrongmeal
force-pushed
the
vrongmeal/copy-to
branch
2 times, most recently
from
a644444 to
63a1ea6
Compare
Fixes #962 Signed-off-by: Vaibhav <[email protected]>
vrongmeal
force-pushed
the
vrongmeal/copy-to
branch
from
63a1ea6 to
8226425
Compare
scsmithr
approved these changes
Jul 4, 2023
| } | ||
| writer.finish().await?; | ||
|
|
||
| Ok(0) |
There was a problem hiding this comment.
Should we always be returning 0, or should this be counting the number of rows being written.
There was a problem hiding this comment.
Aah yes, we should technically be returning number of rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #962