add support for reading from "file://" for parquet_scan
#1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
universalmind303
changed the title
parquet_scan
scsmithr
approved these changes
Jun 21, 2023
| pub trait TableAccessor: Send + Sync { | ||
| fn store(&self) -> &Arc<dyn ObjectStore>; | ||
|
|
||
| fn object_meta(&self) -> &Arc<ObjectMeta>; | ||
| async fn into_table_provider(self, predicate_pushdown: bool) -> Result<Arc<dyn TableProvider>>; |
There was a problem hiding this comment.
imo we should remove predicate_pushdown (can do later). I don't know when there's a time where we don't want this.
There was a problem hiding this comment.
if we remove, then couldn't we just change this use the std TryInto?
There was a problem hiding this comment.
Nah, we still need it be async since there's a bit of setup done in this function for some data sources (e.g. for postgres we need to make a connection and run a query to get the schema).
There was a problem hiding this comment.
I mean would could do IntoFuture (https://doc.rust-lang.org/std/future/trait.IntoFuture.html), but I'm not really feelin it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up from #1160.
in addition to the
http/httpsschemes, we also supportfile://