fix: Support null credentials for object store access. #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCS works (raising a PR for NULL Credentials): ``` > select * from 'gs://vrongmeal-public-test/data.csv'; ┌───────┬─────────┐ │ id │ name │ │ ── │ ── │ │ Int64 │ Utf8 │ ╞═══════╪═════════╡ │ 1 │ vaibhav │ │ 2 │ sean │ │ 3 │ grey │ └───────┴─────────┘ ``` Need to make a similar change upstream for S3 and Azure. Fixes: #1065 Signed-off-by: Vaibhav <[email protected]>
tychoish
reviewed
Mar 20, 2024
| | AzureConfigKey::SasKey | ||
| | AzureConfigKey::Token | ||
| ) { | ||
| creds = true; |
Comment on lines
+102
to
+104
| if !creds { | ||
| builder = builder.with_credentials(Arc::new(NullCredentialProvider)); | ||
| } |
There was a problem hiding this comment.
could we create a build with null credentials, and then override it if/as we find credentials, and avoid the bool?
universalmind303
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCS works (raising a PR for NULL Credentials):
Need to make a similar change upstream for S3 and Azure.
Fixes: #1065