-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter table rename #848
Alter table rename #848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will be a good thing to test with SLTs.
Something like
statement ok
create schema rename_tables_test;
statement ok
set search_path = rename_tables_test;
statement ok
set enable_debug_datasources to t;
statement ok
create external table t1 from debug options (table_type = 'never_ending');
statement ok
alter table t1 rename to t2;
...
nvm I see you edit the proto files and it generates the code, not the other way around. 👍 |
Realize I also still need to properly parse the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Just the one comment about returning error when removing from entries. @scsmithr how do you feel about that?
@scsmithr it seems that the default alter table parse doesn't seem to give me an |
45940a2
to
b058a96
Compare
Let's skip and open an issue for it. It should be easy to add to the upstream lib. |
c7530e7
to
349fe55
Compare
I think this works, still need to test in dev
closes #809