Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update VirtualLister to specify schema if one exact present #849

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

vrongmeal
Copy link
Contributor

This is so we can specialize for the case of BigQuery.

@vrongmeal vrongmeal requested a review from scsmithr April 11, 2023 20:04
Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Postgres SLT failure seems like it's just from renaming "virtual_datasource_schema" to "virtual_catalog".

Also we'll definitely want better errors if the schema doesn't actually exist in the external databases...

@vrongmeal
Copy link
Contributor Author

Also we'll definitely want better errors if the schema doesn't actually exist in the external databases...

I didn't understand this. When do we want to return an error?

This is so we can specialize for the case of BigQuery.

Signed-off-by: Vaibhav <[email protected]>
@vrongmeal vrongmeal force-pushed the vrongmeal/virtual-catalog branch from e56806c to 52ce6b9 Compare April 12, 2023 08:52
@vrongmeal vrongmeal enabled auto-merge (squash) April 12, 2023 09:11
@vrongmeal vrongmeal merged commit fff11d6 into main Apr 12, 2023
@vrongmeal vrongmeal deleted the vrongmeal/virtual-catalog branch April 12, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants