Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter database rename #853

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Alter database rename #853

merged 7 commits into from
Apr 12, 2023

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Apr 12, 2023 •
edited
Loading

Closes #810

@f0ssel f0ssel force-pushed the f0ssel/rename-db branch from 4757437 to d1691d1 Compare April 12, 2023 19:14
@f0ssel f0ssel requested review from scsmithr and vrongmeal April 12, 2023 19:15
scsmithr
scsmithr reviewed Apr 12, 2023
View reviewed changes
vrongmeal
vrongmeal previously requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@vrongmeal vrongmeal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ what sean said (i think i repeated the tests thing)

@f0ssel f0ssel requested review from scsmithr and vrongmeal April 12, 2023 20:30
@f0ssel
Copy link
Contributor Author

f0ssel commented Apr 12, 2023

Thanks for the reviews, I believe I've addressed all comments in the latest commit.

@f0ssel f0ssel dismissed vrongmeal’s stale review April 12, 2023 20:51

made changes

@f0ssel f0ssel enabled auto-merge (squash) April 12, 2023 20:52
@f0ssel f0ssel merged commit bb17cc4 into main Apr 12, 2023
@f0ssel f0ssel deleted the f0ssel/rename-db branch April 12, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scsmithr scsmithr scsmithr approved these changes

@vrongmeal vrongmeal Awaiting requested review from vrongmeal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add database renaming
3 participants
@f0ssel @scsmithr @vrongmeal