feat: implement virtual catalog for snowflake #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scsmithr
approved these changes
Apr 14, 2023
| let res = self | ||
| .conn | ||
| .query( | ||
| "SELECT schema_name FROM information_schema.schemata".to_string(), |
There was a problem hiding this comment.
Here's hoping there's not some crazy minimum like in BigQuery.
There was a problem hiding this comment.
I checked, couldn't find anything like that. Though, it does mention to "optimize queries" to return results else for too much data it might just error 😛
Also fix a bug in snowflake row iterator where it panics when the first batch has 0 rows (i.e., it's essentially empty). Signed-off-by: Vaibhav <[email protected]>
vrongmeal
force-pushed
the
vrongmeal/snowflake-virtual-catalog
branch
from
1290158 to
c12a7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a bug in snowflake row iterator where it panics when the first batch has 0 rows (i.e., it's essentially empty).