Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to prevent creation of empty nodesets #3426

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

abbas1902
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 requested a review from mr0re1 December 18, 2024 21:55
@abbas1902 abbas1902 added release-chore To not include into release notes bug Something isn't working and removed release-chore To not include into release notes bug Something isn't working labels Dec 18, 2024
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Dec 19, 2024
@abbas1902 abbas1902 enabled auto-merge December 19, 2024 02:28
@abbas1902 abbas1902 merged commit 422aebf into GoogleCloudPlatform:develop Dec 19, 2024
8 of 62 checks passed
@abbas1902 abbas1902 deleted the empty branch December 19, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants