-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES #498: http2 translated to Spanish #1856
ES #498: http2 translated to Spanish #1856
Conversation
Thanks - will check it out!
If they are small and you're reasonably certain they are errors (e.g. typos) can you add to this pull request? If you've questions or want to clarify something is correct can you raise an issue to discuss first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good translation (at least technically - can't talk to the Spanish unfortunately!)
Spotted a few things minor things to fix though (which should also fix the reasons for the tests failing).
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Thanks for the review! I will modify the spaces and erase the "to do" from the english version as well. |
Oh dunno how we missed that! I can see the new figures in the link sheets so let’s fix that here since you’re editing both files anyway. Gimme a few mins... |
Oh ok! I have changed the other errors I've found.. can you confirm you see them? I will update when you're done fixing the tables! |
Co-authored-by: Barry Pollard <[email protected]>
I think it's all ready.. ! @bazzadp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this - and for fixing the English version!
Ideally one of the other @HTTPArchive/spanish-translators will give the language a once over but if I don't hear anything by time of next release then will merge this in. Have a few outstanding pull requests there so will wait and see if we can merge any of those over next few days before doing a release.
In some links I added hreflang="en" and for some words, lang="en" inside the italics tag
Makes progress on #498
This is my first chapter, please if you have any comments, I would appreciate it.
I also found some errors in the source content in English, who should I tell?
Thanks!