Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES #498: http2 translated to Spanish #1856

Merged
merged 14 commits into from
Jan 3, 2021

Conversation

moniloria
Copy link
Contributor

@moniloria moniloria commented Dec 30, 2020

In some links I added hreflang="en" and for some words, lang="en" inside the italics tag

Makes progress on #498

This is my first chapter, please if you have any comments, I would appreciate it.

I also found some errors in the source content in English, who should I tell?

Thanks!

@moniloria moniloria added good first issue Good for newcomers translation world wide web labels Dec 30, 2020
@moniloria moniloria added this to the 2020 Content Translation milestone Dec 30, 2020
@moniloria moniloria self-assigned this Dec 30, 2020
@tunetheweb
Copy link
Member

Thanks - will check it out!

I also found some errors in the source content in English, who should I tell?

If they are small and you're reasonably certain they are errors (e.g. typos) can you add to this pull request? If you've questions or want to clarify something is correct can you raise an issue to discuss first?

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good translation (at least technically - can't talk to the Spanish unfortunately!)

Spotted a few things minor things to fix though (which should also fix the reasons for the tests failing).

@tunetheweb tunetheweb requested a review from a team December 30, 2020 12:37
@moniloria
Copy link
Contributor Author

moniloria commented Dec 30, 2020

Thanks - will check it out!

I also found some errors in the source content in English, who should I tell?

If they are small and you're reasonably certain they are errors (e.g. typos) can you add to this pull request? If you've questions or want to clarify something is correct can you raise an issue to discuss first?

Thanks for the review! I will modify the spaces and erase the "to do" from the english version as well.
The errors I found are only 1 typo (sever where it should say server), 2 errors in the figure description (copying the wrong numbers) and I also found a table that has all the numbers off! (figure 22.17 and 22.18 are the same!) I think I can fix the first 3 errors but I will raise an issue for the last one!

@tunetheweb
Copy link
Member

I also found a table that has all the numbers off! (figure 22.17 and 22.18 are the same!)

Oh dunno how we missed that! I can see the new figures in the link sheets so let’s fix that here since you’re editing both files anyway. Gimme a few mins...

@moniloria
Copy link
Contributor Author

I also found a table that has all the numbers off! (figure 22.17 and 22.18 are the same!)

Oh dunno how we missed that! I can see the new figures in the link sheets so let’s fix that here since you’re editing both files anyway. Gimme a few mins...

Oh ok! I have changed the other errors I've found.. can you confirm you see them? I will update when you're done fixing the tables!

@moniloria
Copy link
Contributor Author

I think it's all ready.. ! @bazzadp

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this - and for fixing the English version!

Ideally one of the other @HTTPArchive/spanish-translators will give the language a once over but if I don't hear anything by time of next release then will merge this in. Have a few outstanding pull requests there so will wait and see if we can merge any of those over next few days before doing a release.

@tunetheweb tunetheweb merged commit f7cf015 into HTTPArchive:main Jan 3, 2021
@moniloria moniloria deleted the es-498-2020-content-http branch January 4, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants