-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2020 javascript japanese translation #1937
2020 javascript japanese translation #1937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me!
Just one last minute change I just put in, this morning.
Not sure if @MSakamaki or @hi-toshi are going to get a chance to review this so going to go ahead and merge this as going a release. Would love to hear you feedback if you do get a chance to review and can fix in a future PR. Thanks for working on this @ksakae1216 ! |
* upstream/main: (70 commits) Do fuller HTML linting checks on generated HTML (HTTPArchive#1959) Extend height of AMP Stories images (HTTPArchive#1957) Change Introductie to Inleiding (HTTPArchive#1956) Bump peter-evans/create-pull-request from v3.7.0 to v3.8.0 (HTTPArchive#1955) Update Timestamps and Generate Ebooks (HTTPArchive#1953) Update total number of pages in ebook to 600! (HTTPArchive#1952) Remove control characters causing HTML validation errors (HTTPArchive#1951) 2020 javascript japanese translation (HTTPArchive#1937) Translation of 2020 accessibility chapter to Japanese (HTTPArchive#1949) Fix figure links and footnotes for ebook (HTTPArchive#1950) Fix hide description bug (HTTPArchive#1948) Update Timestamps and Generate Ebooks (HTTPArchive#1947) Smart Quotes for English non-chapter pages (HTTPArchive#1946) Typographical quotes for metadata (HTTPArchive#1945) Fix figure number bug (HTTPArchive#1944) Update Timestamps and Generate Ebooks (HTTPArchive#1943) Revert "Revert "Add typographic punction conversion"" (HTTPArchive#1942) Add Nuxt and Docusauraus to Jamstack 2020 chapter (HTTPArchive#1938) Revert "Add typographic punction conversion" Add typographic punction conversion ...
Please review for me.
Part of #586