Validate chapters, languages and years #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
reviewed
Apr 6, 2020
rviscomi
reviewed
Apr 6, 2020
rviscomi
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400
Fixes #713
Makes progress on #686
This implements @arsenicraghav 's fix for hardcoded chapters in validation (#400) from #557 (though in config.py instead of validate.py to avoid multiple loads of JSON file). We had delayed this before but we're not making any progress on #561 and not entirely convinced we should do that any more anyway!
It also allows loading of multiple year config JSONs (#713 ) including the ability to exclude some years in JSON config (while we work on them and before they are ready for release).
It also makes languages configureable per year and in JSON as part of #686. The JavaScript side still needs to be done.