This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
New A11Y metrics #216
Merged
New A11Y metrics #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
suggested changes
Jun 28, 2021
custom_metrics/a11y.js
Outdated
| ]; | ||
|
|
||
| const stats_of_controls = []; | ||
| for (const node of $WPT_ACCESSIBILITY_TREE) { |
There was a problem hiding this comment.
I'd suggest declaring a const at the top of the file that aliases $WPT_ACCESSIBILITY_TREE, so that there's only one version of it that needs to be expanded in case anyone wants to add a new custom metric that depends on it.
There was a problem hiding this comment.
Change made in latest commit. This what you were envisioning?
Co-authored-by: Rick Viscomi <[email protected]>
rviscomi
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on HTTPArchive/almanac.httparchive.org#2147
This PR adds five new metrics:
form_control_a11y_tree: A slimmed down version of the browser accessibility tree for form controls (select, input, textarea, buttons)fieldset_radio_checkbox: Documents how many radios and checkboxes there are. Then checks how many of those inputs are correctly placed in a fieldset with a legendrequired_form_controls: Scans for all the required form controls on the page. Looks forrequired,aria-required, or an asterisk at the start or end of the visible label<audio>elements and their<track>stotal_with_trackmetric to thevideossection in almanac.jsThis code has been tested on custom built pages (example) and amazon.com (stress test for large amounts of elements) and passed the tests.
Amazon.com test
Custom page test