Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bgm fallback for empty lines in meta data #21

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Handle bgm fallback for empty lines in meta data #21

merged 1 commit into from
Dec 12, 2022

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Dec 12, 2022

Adds string empty check for type fallback in sequence parsing.

fixes #20

dcvz
dcvz approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @Archez

@dcvz dcvz merged commit 33757c6 into HarbourMasters:main Dec 12, 2022
@Archez Archez deleted the bgm-fallback branch December 12, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcvz dcvz dcvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequences: BGM fallback not accounting for blank lines in .meta files
2 participants
@Archez @dcvz