Check prime with and without recursion in java #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solving the question Prime Number with iteration as well as recursion HarshCasper#1372
iamrajiv
suggested changes
Dec 2, 2020
There was a problem hiding this comment.
@ErzaTitania-2001 Add sample input-output, space and time complexity. Also, update the README file.
|
Okay!
I'm working on it.
I need to add sample input and output cases as the comment lines in he
program?
…On Wed, 2 Dec, 2020, 11:53 AM Rajiv Singh, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@ErzaTitania-2001 <https://github.com/ErzaTitania-2001> Add sample
input-output, space and time complexity. Also, update the README file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1417 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJCY2D3N54R5YML4KAV4XDSSXMNDANCNFSM4UKAE37Q>
.
|
|
@ErzaTitania-2001 Yes. Also, you can refer to other programs for reference. |
iamrajiv
suggested changes
Dec 2, 2020
There was a problem hiding this comment.
@ErzaTitania-2001 Add your program links in Java/README.md.
|
Oh. I'm so sorry. I'll remove my commit for Contributors.md right now.
…On Wed, 2 Dec, 2020, 1:51 PM Rajiv Singh, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@ErzaTitania-2001 <https://github.com/ErzaTitania-2001> Add your program
links in Java/README.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1417 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJCY2CN6I7NAX3N5PUIS5LSSX2HTANCNFSM4UKAE37Q>
.
|
|
Review the changes and if required do suggest more! @iamrajiv @atarax665 |
iamrajiv
approved these changes
Dec 2, 2020
|
@all-contributors please add @ErzaTitania-2001 for code |
|
I've put up a pull request to add @ErzaTitania-2001! 🎉 |
ankitaggarwal23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the question Prime Number with iteration as well as recursion #1372
Have you read the Contributing Guidelines on Pull Requests?
Yes
Checklist
README.mdand link to my code.Related Issues or Pull Requests
Prime Number #1372