Merge Sort Using recursion In Java #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamrajiv @atarax665 kindly do go through my PR. |
iamrajiv
suggested changes
Dec 10, 2020
|
Okay. Thank you for the insight! I'll change it right away.
…On Thu, 10 Dec, 2020, 12:48 PM Rajiv Singh, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In Java/README.md
<#1437 (comment)>
:
> @@ -138,6 +138,7 @@ _add list here_
- [PancakeSort](sort/PancakeSort.java)
- [Quick Sort](sort/QuickSort.java)
- [Selection Sort](sort/SelectionSort.java)
+- [Merge Sort Using Recursion](https://github.com/ErzaTitania-2001/NeoAlgo/blob/master/Java/sort/MergeSortRecursion.java)
It should be like this - [Merge Sort Using
Recursion](sort/MergeSortRecursion.java).
------------------------------
In Java/sort/MergeSortRecursion.java
<#1437 (comment)>
:
> @@ -0,0 +1,107 @@
+//merge sort using divide and conquer and recursion
+import java.util.Scanner;
+class MergeSortRecursion
+{
+
+ public static void sort(int arr[], int start, int end)
+ {
+ if(start==end) //base case
+ return;
+ else
+ {
+ // Find the mid of the array
+ int mid = (start + end) / 2;
@ErzaTitania-2001 <https://github.com/ErzaTitania-2001> Please avoid this
technique to find the mid element since this can cause an integer overflow.
Use this int int mid = start + ((end - start) / 2);.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1437 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJCY2AONE7P6545LY7BW63SUBY2VANCNFSM4UTWYE7Q>
.
|
/changed done.
|
Changes done. Go through the PR as required. @iamrajiv @atarax665 |
iamrajiv
approved these changes
Dec 10, 2020
|
Can we create another pull request without the current one being merged? @iamrajiv |
|
I've put up a pull request to add @ErzaTitania-2001! 🎉 |
ankitaggarwal23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines on Pull Requests?
yes
Description
(Write your answer here.)
Checklist
README.mdand link to my code.Related Issues or Pull Requests
Merge Sort in JavaScript #1427
#1427
Labelled Java