Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong Number Using Indirect recursion #1564

Merged
merged 14 commits into from
Dec 20, 2020

Conversation

ErzaTitania-2001
Copy link
Contributor

Have you read the Contributing Guidelines on Pull Requests?

yes

Description

(Write your answer here.)

Checklist

  • [ yes] I've read the contribution guidelines.
  • [yes ] I've checked the issue list before deciding what to submit.
  • [ yes] I've edited the README.md and link to my code.

Related Issues or Pull Requests

Math Programs (WoC) #1527

@ErzaTitania-2001
Copy link
Contributor Author

@iamrajiv check my PR for any discrepancies and inform me if any!
Issue in question Math Programs (WoC) #1527

@@ -0,0 +1,47 @@
//checking for a strong number using indirect recursion
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description of the Algorithm/Code that you are looking to implement

import java.util.*;
class StrongRecursion
{
public static int sofd(int n) //recursive function for sum of factorial of digits
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use meaningful function and variable names

*
*
*/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline at the end of the file

Added description of algorithm/code
Changed function name
Modified comment lines
Made user input more friendly
Added new line at the EOF
Copy link
Contributor Author

@ErzaTitania-2001 ErzaTitania-2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done @HarshCasper . Go over it.

*
*/


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra lines of code

}
}

/* Sample Input And Output ;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: not ;

public static int sumOfFactorialOfDigit(int n)

{
if(n==0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the Code with spaces around the Operators

Removed extra lines of code
Formatted space around operators
Copy link
Contributor Author

@ErzaTitania-2001 ErzaTitania-2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any other problems present than indentation, do say @HarshCasper

Copy link
Contributor

@iamrajiv iamrajiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErzaTitania-2001 Rename the program to check_strong_number.java. Also, Format your code using code formatter.

Copy link
Contributor

@iamrajiv iamrajiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErzaTitania-2001 Rename the program StrongRecursion.java to check_strong_number.java.

@ErzaTitania-2001
Copy link
Contributor Author

@iamrajiv , should I close this pull request ? I want to pull another request on another program.

Copy link
Contributor

@vatsalkesarwani12 vatsalkesarwani12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ErzaTitania-2001
Copy link
Contributor Author

@HarshCasper @iamrajiv , I made a commit for the issue Bucket Sort #1590 in the same pull request by mistake. Any solutions to this problem?

Copy link
Contributor

@iamrajiv iamrajiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErzaTitania-2001 Remove the Bucket Sort program from this PR and make another PR for Bucket Sort. Also, whenever you make PR make separate branches for each PR rather than committing to the master branch.

@ErzaTitania-2001
Copy link
Contributor Author

@iamrajiv Done. Deleted Bucket_Sort. When is the PR gonna be merged?

@iamrajiv iamrajiv merged commit 9a44823 into HarshCasper:master Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants