Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-fix: isImportedFromCode memo race condition #3366

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

tinomarques
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 11:52pm
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 11:52pm
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 11:52pm

Copy link
Contributor

promptless bot commented Mar 3, 2025

✅ No documentation updates required.

Copy link

fumedev bot commented Mar 4, 2025

Summary

  • Fixes a race condition in the isImportedFromCode memoization logic in the PromptEditor component.
  • Ensures correct evaluation of whether a prompt is imported from code based on specific conditions.
  • Removes console log statements throughout several components to clean up debug output.
  • Updates related functionality in the PromptBox component to handle suggestion fetching more reliably.
  • Adds handling for undefined state during loading to prevent premature access to the isImportedFromCode value.

@chitalian chitalian merged commit fec6797 into main Mar 4, 2025
7 of 9 checks passed
@chitalian chitalian deleted the hotfix-importedfromcode-memo branch March 4, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants