Fixed adaptability on the solutions page. Issues #1584 #1652
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artengin можете задеплоить демо на render чтобы посмотреть визуально? |
|
Ссылка на демо: https://artengin-sicp.onrender.com/ |
|
@amshkv посмотри, пожалуйста, ок ли ок. |
amshkv
reviewed
Jan 27, 2025
resources/sass/_custom.scss
Outdated
| @@ -36,6 +36,19 @@ | |||
| } | |||
| } | |||
|
|
|||
| @media (max-width: 768px) { | |||
There was a problem hiding this comment.
https://getbootstrap.com/docs/5.3/layout/breakpoints/#min-width
а почему не пользуешься бутстраповскими переменными?
There was a problem hiding this comment.
Добавил бутстраповские переменные, для этого пришлось создать новый scss файл и подключать его после импорта бутстрап.
Не знаю правильно ли я сделал.
Все работает, но Codacy ругается, потому что не поймет что такое @include
amshkv
reviewed
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Исправил адаптивное отображение фильтра "Пользователь; Упражнение" на странице /solutions
Примеры на экранах шириной больше 768px
Было:
Стало:
Примеры на экранах шириной больше 576px
Было:
Стало:
Примеры на экранах шириной меньше 576px
Было:
Стало: