Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new rigid registration algorithm RigidGridStart that initialize… #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cody-G
Copy link

@Cody-G Cody-G commented Jan 5, 2018

…s with a gridsearch of rotations+shifts.
Requires HolyLab/BlockRegistration.jl#73

@Cody-G
Copy link
Author

Cody-G commented Jan 5, 2018

I was torn about whether to add a feature to the existing Rigid algorithm or to create a new algorithm and leave that one untouched. I went with the latter, but I'm open to other ideas.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better as a separate algorithm. Nice work!

"""
`RigidGridStart(fixed, maxradians, rgridsz, mxshift; thresh_fac=(0.5)^ndims(fixed), thresh=nothing, SD = eye(ndims(fixed)), pid=1, kwargs...)`
initializes the `RigidGridStart` registration algorithm. This algorithm works much like `Rigid` except that instead of initializing with a
principle axis transformation it intializes with a grid search of rotations+shifts. Possible shifts are specified by `mxshift` while rotations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

principal, not principle

@Cody-G
Copy link
Author

Cody-G commented Feb 18, 2018

It seems the build is failing because it can't build CUDArt. I didn't change anything related to CUDArt in this PR. My memory may be incorrect but I believe in the past we intelligently skipped building CUDArt when building on Travis. Any idea what's changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants