[#183342339] Merge and combine latest django-cron changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to write to, or unlink the lock file. Rely on kernel-level file locking mechanisms (fcntl) instead. The lock will be held for the duration of the process. Locking will always fail if another process has locked the file. Unlocking can be done explicitely, but will also always happen implicitly at process termination.
Update sample_cron_configurations.rst
Changed deafult to default.
Fixed typo in sample_cron_configurations.rst
…run_at_times or run_every_mins) closes Tivix#115
It is possible for the running lock date in the cache to be None if another process released the lock before the current process fetched the value from the cache.
py3k fixes
Prevent AttributeError when lock date is None.
Send mail when more than minimum of failures
(docs) Tiny grammar fixes in README and introduction
+ URL include fix + Test Settings template context processor fix + Exclude Python 2.7 / Django 2.0 combination from tests
This parameter (schedule.run_tolerance_seconds) allows to run the job slightly earlier. For example, consider a job that runs every 5 minutes and last time it was run at 00:00:00. For example, runcrons command gets called every five minutes starting from 00:00:00. Without this parameter, the job will be run next time at 00:10:00. If run_tolerance_seconds is set to non-zero value, the job will be run next time at 00:05:00. That makes job run period more precise. By default, run_tolerance_seconds is 0, so this does not affect existing jobs.
Remove succeed cron job logs
…-from-checking-if-cron-should-run Issue/80 exclude future dates from checking if cron should run
…ango3-cron-183342339
Fix migrations
django-common-helpers dependency has code incompatible with django 4 https://docs.djangoproject.com/en/4.0/ref/utils/#module-django.utils.encoding
There is no Django 4 compatible django-common-helpers and it is still used in django_cron.cron.FailedRunsNotificationCronJob
GitTiago
force-pushed
the
feature/django3-cron-183342339
branch
from
9cd1fe6 to
349dbe7
Compare
GitTiago
force-pushed
the
feature/django3-cron-183342339
branch
from
349dbe7 to
46a040c
Compare
.github/workflows/django.yml
Outdated
| max-parallel: 4 | ||
| matrix: | ||
| python-version: [3.7, 3.8, 3.9] | ||
| django_version: [<3, <4] |
There was a problem hiding this comment.
Is there a reason we're not specifying 2.2 here? 🤔
There was a problem hiding this comment.
not really it's usually equivalent, when you specify <3 it install the latest version under version 3, i.e 2.2.X whatever is in vogue
Comment on lines
+22
to
+23
| - python: "3.7" | ||
| env: DJANGO=2.0.* DJANGO_SETTINGS_MODULE='settings_sqllite' |
There was a problem hiding this comment.
Presumably we don't need to update this to include every single combination, right? Shouldn't this be the LTS version of 2.2 over 2.0?
Also I notice there doesn't seem to be a Django 3 and postgres settings set up? Should there be?
There was a problem hiding this comment.
travis tests is not used. It was migrated from travis to Github actions
docs/sample_cron_configurations.rst
Outdated
| @@ -87,7 +162,7 @@ is set to run on each ``runcrons`` task, and the default process is to email | |||
| all the users specified in the ``ADMINS`` settings list when a job fails more | |||
| than 10 times in a row. | |||
|
|
|||
| Install required dependencies: ``Django>=1.7.0``, ``django-common>=0.5.1``. | |||
| Install required dependencies: ``Django>=3.2.0``. | |||
There was a problem hiding this comment.
Does this run the risk of installing a higher version of django than we want?
| mysqlclient==1.3.6 | ||
| psycopg2==2.6 | ||
| psycopg2==2.9.3 |
There was a problem hiding this comment.
mysqlclient gets removed here - but the travis file mentions set up with sql settings - am I missing something here?
There was a problem hiding this comment.
Travis file is no used unfortunately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine Housekeep authored migrations and tests with latest django-cron changes