-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tamil translations #979
Merged
clairernovotny
merged 13 commits into
Humanizr:master
from
ammahir:mohamedmahir-tamil-1
Sep 30, 2020
Merged
Add tamil translations #979
clairernovotny
merged 13 commits into
Humanizr:master
from
ammahir:mohamedmahir-tamil-1
Sep 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #979 |
Closed
clairernovotny
requested changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this translation. We can merge this after the two small items are addressed. We let the commit history serve as credit.
src/Humanizer/Localisation/NumberToWords/TamilNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
src/Humanizer/Localisation/NumberToWords/TamilNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
Minor clean up prior to merge
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a checklist you should tick through before submitting a pull request:
dev
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failures