Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tamil translations #979

Merged
merged 13 commits into from
Sep 30, 2020
Merged

Conversation

ammahir
Copy link
Contributor

@ammahir ammahir commented Sep 20, 2020

Here is a checklist you should tick through before submitting a pull request:

  • [ X] Implementation is clean
  • [X ] Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings
  • [ X] There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • [X ] There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • [ X] Run either build.cmd or build.ps1 and ensure there are no test failures

@ammahir
Copy link
Contributor Author

ammahir commented Sep 20, 2020

closes #979

@ammahir ammahir marked this pull request as ready for review September 24, 2020 03:38
@ammahir ammahir mentioned this pull request Sep 30, 2020
Copy link
Member

@clairernovotny clairernovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this translation. We can merge this after the two small items are addressed. We let the commit history serve as credit.

Minor clean up prior to merge
@clairernovotny clairernovotny merged commit 7d367e1 into Humanizr:master Sep 30, 2020
@clairernovotny clairernovotny linked an issue Oct 1, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tamil Translations
2 participants