Scroll and Dropdown features are now responsive for Provider Management and Analyzer test name pages. #1467
Conversation
Signed-off-by: Vaishnavi Bhandari <[email protected]>
|
Hi, I have a small query. Every time I generate a pull request, even after I resolve the conflicts, github says my branch is out of date and as soon as I update my branch it starts running tests again? So should I not update my branch every time I open a PR? |
Signed-off-by: Vaishnavi Bhandari <[email protected]>
|
👋 Hi, @peach280, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
can you run the formatter to format you code ?? |
| @@ -403,13 +403,8 @@ function ProviderMenu() { | |||
| value={telephone} | |||
| onChange={(e) => setTelephone(e.target.value)} | |||
| /> | |||
| <TextInput | |||
There was a problem hiding this comment.
any reason you shifted this field below ??
There was a problem hiding this comment.
Actually according to this issue #1410 the user was not able to see the options in dropdown menu as it wasn't auto scrolling. So I shifted the dropdown above so that user can see without scrolling.
| @@ -369,18 +369,6 @@ function AnalyzerTestName() { | |||
| setSelectedAnalyzerId(selectedItem ? selectedItem.id : null); | |||
| }} | |||
| /> | |||
| <br /> | |||
| <TextInput | |||
There was a problem hiding this comment.
any reason you shifted the field ??
There was a problem hiding this comment.
In this dropdown when expanded wasn't visible so I shifted it above.
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
I ran the formatter still failing. |
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
|
Hi @mozzy11 I have made the design responsive by shifting dropdown menu above but I had one query.
The first dropdown menu in Analyzer Test Name called Analyzer, is displaying contents of analyzerlist and I logged it in console and this list is empty that's why the dropdown is empty. To populate this list there is an api call being made the address of which I can't find in the codebase. Your guidance will really help me in solving this issue. |
|
Fix the formatting issues , but also do the same for the Update Models too and attach a screen recording for both the Add and Update models |
|
Ok I will surely do that, but what about the first analyser whose drop-down is empty, as mentioned here #1467 (comment) |
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
OpenELIS.-.Google.Chrome.2025-02-21.09-42-04.mp4Made the dropdown responsive for provider management. Screen Recording attached. |
|
👋 Hi, @peach280, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
@peach280 can you fix the merge conflicts here ? |
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Fixes #1410
The Provider Management page and Analyzer test page have been made responsive with the dropdown menu.
OpenELIS.-.Google.Chrome.2025-01-29.23-35-40.mp4