Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Style.css for Enhancing code quality Readibilty and Maintainabilty #1481

Merged
merged 9 commits into from
Feb 24, 2025

Conversation

Raghavjha60570
Copy link
Contributor

Screenshot 2025-01-31 201622

Screenshot 2025-01-31 201655
Screenshot 2025-01-31 201710
Screenshot 2025-01-31 201749
Screenshot 2025-01-31 201803
Screenshot 2025-01-31 201831
Screenshot 2025-01-31 201841
Screenshot 2025-01-31 201902

Pull Requests Requirements

  • [ ✔] The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • [ ✔] The PR includes a video showing the changes for the work done.
  • [✔ ] The PR title follows conventional commit label standards.
  • [ ✔] The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • [ ✔] The changes include tests or are validated by existing tests.
  • [✔ ] I have read and agree to the Contributing Guidelines of this project.

Summary

Removed duplicate CSS rules to improve maintainability.
Refactored styles for better readability and efficiency.
Ensured consistency in spacing, colors, and typography.
Avoided the use of @extend due to compatibility issues.

@Agaba-derrick
Copy link
Contributor

hey @Raghavjha60570 thanks for the work done !
have you thought about using Carbon Design System components instead of Custom Css?Z
By using Carbon’s grid, buttons, and form elements, we also align with best practices for accessibility and theming, reducing the need for individual custom CSS properties.

@Raghavjha60570
Copy link
Contributor Author

Hey @Agaba-derrick Sorry for the late Response and Thank You For the Suggestion! I appreciate the feedback i haven't used Carbon design system components before but I'd Love to explore Integrating them into the project. Should i Refactor The exstings Style into Carbon grid ,button or Form element? Also are there any specific guidlines or components I should priortize ?

@mozzy11
Copy link
Collaborator

mozzy11 commented Feb 24, 2025

Thanks @Raghavjha60570 .
Can you run the frontend formatter ???

@mozzy11 mozzy11 merged commit 111cb63 into I-TECH-UW:develop Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants