Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve duplicate photos from article pages #124

Closed
MirandaEcho opened this issue Nov 14, 2019 · 2 comments
Closed

Resolve duplicate photos from article pages #124

MirandaEcho opened this issue Nov 14, 2019 · 2 comments
Labels
Priority: Normal Must be completed in this release.

Comments

@MirandaEcho
Copy link
Collaborator

Programatically remove the article image that's in the top of the content area.

In the rare case when then featured image and the top image are different, it's fine to supplant the top image with the featured image.

@MirandaEcho MirandaEcho added the Priority: Normal Must be completed in this release. label Nov 14, 2019
@benlk
Copy link
Collaborator

benlk commented Nov 14, 2019

This is what we'd need to remove to fix the problem: https://github.com/INN/umbrella-citylimits/blob/master/wp-content/themes/citylimits/inc/post-templates.php

Are we worried about historic content?

@benlk
Copy link
Collaborator

benlk commented Nov 14, 2019

That doesn't actually fix the problem, it turns out. The real cause of the duplicate image was because when I created single-two-column.php for #99, I included largo_hero( null,'' ); from Largo's template. Since #5, City Limits had been using versions of the single-column and double-column templates that did not output the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Normal Must be completed in this release.
Projects
None yet
Development

No branches or pull requests

2 participants