-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run works locally. Problem in ports UI: integer types don't show corr… #1
Conversation
.osparc/metadata.yml
Outdated
contentSchema: | ||
title: Compression level | ||
type: integer | ||
default: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcrespov, in the UI, I don't see the default value I have here. Would you see why that happens? How can I debug this? I have it running in my local deploy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at first sight it looks correct to me https://json-schema.org/understanding-json-schema/reference/numeric.html
Try this: make input_2.label
the same as input_2.contentSchema.title
. Perpahs there is bug ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it didn't work. I got the impression that we don't do anything with default
if provided within the contentSchema
.
And if understood this well, default is just an "annotation": https://stackoverflow.com/a/72048005
I solved by changing to:
input_2:
displayOrder: 2
label: Compression level
description: Compression level (-c)
defaultValue: 0
type: ref_contentSchema
contentSchema:
title: Compression level
type: integer
minimum: 0
maximum: 9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well I guess this follows the node json schema @pcrespov .
@@ -4,3 +4,6 @@ services: | |||
build: | |||
dockerfile: docker/custom/Dockerfile | |||
target: production | |||
args: | |||
- KWAVE_LOGIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are you passing these?? They should go as environs on the service, no? Perhaps you should use oenvs
for that... It is under development in ITISFoundation/osparc-simcore#3565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope @pcrespov, I don't think this are environs of the service.
I use them during building to download the executable of this tool from a website that requires login. See here:
https://github.com/ITISFoundation/k-wave/blob/first_version/docker/custom/Dockerfile#L49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
echo "Setting/getting CPU limit gives this: ${SIMCORE_NANO_CPUS_LIMIT}" | ||
if [ "${SIMCORE_NANO_CPUS_LIMIT}" -ne "0" ] | ||
then | ||
echo "Found NANO_CPU limits: ${SIMCORE_NANO_CPUS_LIMIT}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mguidon, mainly for curiosity:
Before I had:
echo "$INFO" "Found NANO_CPU limits: ${SIMCORE_NANO_CPUS_LIMIT}"
But I had an unbound variable
error in my local oSPARC deploy.
I had to remove "$INFO" to make it work. I am not sure if this is due to something that has changed with the log levels.
This creates the k-wave service.
related to: ITISFoundation/osparc-issues#694