Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run works locally. Problem in ports UI: integer types don't show corr… #1

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

elisabettai
Copy link
Collaborator

This creates the k-wave service.

related to: ITISFoundation/osparc-issues#694

@elisabettai elisabettai requested a review from pcrespov June 23, 2023 16:05
contentSchema:
title: Compression level
type: integer
default: 1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcrespov, in the UI, I don't see the default value I have here. Would you see why that happens? How can I debug this? I have it running in my local deploy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first sight it looks correct to me https://json-schema.org/understanding-json-schema/reference/numeric.html

Try this: make input_2.label the same as input_2.contentSchema.title. Perpahs there is bug ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it didn't work. I got the impression that we don't do anything with default if provided within the contentSchema.

And if understood this well, default is just an "annotation": https://stackoverflow.com/a/72048005

I solved by changing to:

  input_2:
    displayOrder: 2
    label: Compression level
    description: Compression level (-c)
    defaultValue: 0
    type: ref_contentSchema
    contentSchema: 
      title: Compression level
      type: integer
      minimum: 0
      maximum: 9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well I guess this follows the node json schema @pcrespov .

@elisabettai elisabettai added this to the Watermelon milestone Jun 23, 2023
@@ -4,3 +4,6 @@ services:
build:
dockerfile: docker/custom/Dockerfile
target: production
args:
- KWAVE_LOGIN
Copy link
Member

@pcrespov pcrespov Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are you passing these?? They should go as environs on the service, no? Perhaps you should use oenvs for that... It is under development in ITISFoundation/osparc-simcore#3565

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope @pcrespov, I don't think this are environs of the service.
I use them during building to download the executable of this tool from a website that requires login. See here:
https://github.com/ITISFoundation/k-wave/blob/first_version/docker/custom/Dockerfile#L49

@elisabettai elisabettai requested review from mguidon and pcrespov June 26, 2023 09:26
@elisabettai elisabettai marked this pull request as ready for review June 26, 2023 09:27
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

echo "Setting/getting CPU limit gives this: ${SIMCORE_NANO_CPUS_LIMIT}"
if [ "${SIMCORE_NANO_CPUS_LIMIT}" -ne "0" ]
then
echo "Found NANO_CPU limits: ${SIMCORE_NANO_CPUS_LIMIT}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mguidon, mainly for curiosity:
Before I had:
echo "$INFO" "Found NANO_CPU limits: ${SIMCORE_NANO_CPUS_LIMIT}"
But I had an unbound variable error in my local oSPARC deploy.

I had to remove "$INFO" to make it work. I am not sure if this is due to something that has changed with the log levels.

@elisabettai elisabettai requested a review from sanderegg June 26, 2023 09:34
@elisabettai elisabettai merged commit 10cb3b7 into main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants